Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added local task registry, improved shared_tasks API. #203

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

s3rius
Copy link
Member

@s3rius s3rius commented Sep 25, 2023

As discussed with @dtatarkin in #202 we need to have a difference between tasks registered by user and shared, that were created using async_shared_broker.

Signed-off-by: Pavel Kirilin <win10@list.ru>
Signed-off-by: Pavel Kirilin <win10@list.ru>
@dtatarkin
Copy link

Thank you very much, this solution works well for me!

Signed-off-by: Pavel Kirilin <win10@list.ru>
@codecov-commenter
Copy link

Codecov Report

Merging #203 (98240e2) into develop (e66f3aa) will increase coverage by 4.93%.
Report is 115 commits behind head on develop.
The diff coverage is 71.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
+ Coverage    67.62%   72.55%   +4.93%     
===========================================
  Files           37       45       +8     
  Lines          942     1472     +530     
===========================================
+ Hits           637     1068     +431     
- Misses         305      404      +99     
Files Changed Coverage Δ
taskiq/abc/middleware.py 100.00% <ø> (ø)
taskiq/abc/result_backend.py 100.00% <ø> (ø)
taskiq/cli/watcher.py 0.00% <ø> (ø)
taskiq/cli/worker/log_collector.py 100.00% <ø> (ø)
taskiq/cli/worker/process_manager.py 0.00% <0.00%> (ø)
taskiq/cli/worker/run.py 0.00% <0.00%> (ø)
taskiq/events.py 100.00% <ø> (ø)
taskiq/result/v1.py 0.00% <0.00%> (ø)
taskiq/result_backends/dummy.py 100.00% <ø> (ø)
taskiq/brokers/zmq_broker.py 44.73% <27.27%> (+4.19%) ⬆️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@s3rius s3rius merged commit 4b8f015 into develop Sep 25, 2023
@s3rius s3rius deleted the feature/local-registries branch September 25, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants