Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct graceful shutdown. #381

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Added correct graceful shutdown. #381

merged 2 commits into from
Nov 21, 2024

Conversation

s3rius
Copy link
Member

@s3rius s3rius commented Nov 21, 2024

Fixes #380
Fixes #325

This PR rewrites graceful shutdowns completely and now it should be able to gracefully wait for all tasks to complete and implement proper reloading.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (317c1d9) to head (3dd6cdd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
taskiq/cli/worker/run.py 0.00% 11 Missing ⚠️
taskiq/receiver/receiver.py 80.00% 3 Missing ⚠️
taskiq/api/receiver.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   73.16%   77.40%   +4.23%     
==========================================
  Files          62       62              
  Lines        1871     1890      +19     
==========================================
+ Hits         1369     1463      +94     
+ Misses        502      427      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s3rius s3rius merged commit e5c6d2b into master Nov 21, 2024
23 checks passed
@s3rius s3rius deleted the feature/graceful-shutdown branch November 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful Shutdown Issue with Taskiq in K8s Graceful shutdown and reload
2 participants