Fix task delay for specific time with milliseconds #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 77.51% 77.54% +0.03%
==========================================
Files 62 62
Lines 1899 1902 +3
==========================================
+ Hits 1472 1475 +3
Misses 427 427 ☔ View full report in Codecov by Sentry. |
s3rius
approved these changes
Feb 4, 2025
|
LGTM. Will be released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
.schedule_by_time()method, I encountered a problem where the task starts more than 1 second earlier than the scheduled time. I believe the scheduler should not start tasks before the specified time.This PR fixes this issue. Also added a test that simulates my problem.