-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for TM1637, TM1638 and MAX7219 Seven-Segment Display #640
Conversation
The same driver (TM1637) would be modified for adding support for TM1638 as well as the MAX7219 seven-segment display. This means, this documentation will have to undergo changes to incorporate TM1638 and MAX7219 shortly (hopefully!). So, question to whoever is in charge of reviewing/merging the documentation (@blakadder ?) - |
i'll just wait till you decide its complete |
Alright then. I will let you know when. Thank you :) |
@ajithvasudevan |
Yes, I just did, found a couple of breakages, and fixed them. |
Thanks @ajithvasudevan Regarding the presentation of commands descriptions in the TM1637.md page, I'm not a big fan of the pictures aligned on the same line as the text: No other comments but the edit on Commands.md adds quite a lot of commands that are very specific to the TM1367. |
Yes, that looks nicer. I've prefixed
I debated this myself, but decided in favor of the current edit to I can still change it as per your suggestion, if you insist. |
I won't insist. I was just sharing my thoughts 😊 |
@blakadder , |
Thanks for all the work! |
It is my pleasure! |
This PR adds TM163x.md ( and related changes to Displays.md, Commands.md, and API.md ), the documentation for the TM1637, TM1638 and MAX7219 Seven Segment Display support for Tasmota (arendst/Tasmota#10889 , arendst/Tasmota#11031 , arendst/Tasmota#11387)