forked from open-webrtc-toolkit/owt-deps-webrtc
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use the dummy address 0.0.0.0:9 in the c= and the m= lines if the
default connection address is a hostname candidate. Using a FQDN in the c= line has caused an inter-op issue with Firefox when hostname candidates are the only candidates gathered when forming the media sections. To address this issue, we use 0.0.0.0:9 when a hostname candidate would be used to populate the c= and the m= lines. The SDP grammar related to ICE candidates has been moved out of RFC8445, and is currently defined in draft-ietf-mmusic-ice-sip-sdp. A FQDN address must not be used in the connection address attribute per the latest draft, if the ICE agent generates local candidates. Also, the wildcard addresses (0.0.0.0 or ::) with port 9 are given the exception as the connection address that will not result in an ICE mismatch. We thus adopt the aforementioned solution after combining these considerations. Bug: chromium:927309, chromium:982108 Change-Id: I3df2db0f154276da39f99650289cf81baa677e74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145280 Commit-Queue: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28547}
- Loading branch information
Qingsi Wang
authored and
Commit Bot
committed
Jul 12, 2019
1 parent
58388aa
commit 3ae59d3
Showing
4 changed files
with
56 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters