Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] replace asyncData with fetch #44

Closed
wants to merge 15 commits into from
Closed

[feat] replace asyncData with fetch #44

wants to merge 15 commits into from

Conversation

anton-karlovskiy
Copy link
Member

@anton-karlovskiy anton-karlovskiy commented Feb 5, 2021 •
edited by pi0
Loading

#41

@vercel
Copy link

vercel bot commented Feb 5, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-movies/nuxt-movies/99uAvVSPCPXoSqTLhDQeuFTXtURh
✅ Preview: https://nuxt-movies-git-fork-anton-karlovskiy-perf-fetch-hook-60c667.vercel.app

pi0
pi0 reviewed Feb 5, 2021
View reviewed changes
pages/index.vue Outdated Show resolved Hide resolved
pages/index.vue
async asyncData({ error }) {
data() {
return {
trendingMovies: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: For data-reuse technique, we need a global store object otherwise fetched data will be lost (refetched) when going to a page and coming back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0 It makes sense. Thank you.

Copy link
Member Author

@anton-karlovskiy anton-karlovskiy Feb 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0 @danielroe @addyosmani
Could you please check #41 (comment)?

pi0
pi0 reviewed Feb 7, 2021
View reviewed changes
pages/genre/_id/movie.vue Outdated Show resolved Hide resolved
@anton-karlovskiy
Copy link
Member Author

@pi0
FYI: I added keep-alive and :keep-alive-props="{ max: 10 }".

@anton-karlovskiy
Copy link
Member Author

@pi0
FYI: I added activated hooks.

@anton-karlovskiy anton-karlovskiy mentioned this pull request Feb 10, 2021
Open
@anton-karlovskiy
Copy link
Member Author

@pi0
Could you please review 7d0c04e?
Thank you.

pi0
pi0 requested changes Feb 16, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move caching logic to tmdbAPI instead of doing inside page:

  • Decouples page cache from data cache
  • Allows universal caching (swr on server and client)
  • Prevent caching duplicate data in memory if two pages fetch same endpoint

@anton-karlovskiy
Copy link
Member Author

anton-karlovskiy commented Feb 25, 2021 •
edited
Loading

Hi @pi0 @danielroe

Decouples page cache from data cache
Allows universal caching (SWR on server and client)
Prevent caching duplicate data in memory if two pages fetch the same endpoint

Actually, I think I have not correctly understood how to approach resolving these issues.
Could you please teach me in detail or give me some relevant articles or links to resources?
Thank you!

@anton-karlovskiy
Copy link
Member Author

@addyosmani
https://nuxt-movies-9fm7b3y46-nuxt-movies.vercel.app/ is the URL to the last deployment for now as the other PR was merged.

@anton-karlovskiy anton-karlovskiy closed this by deleting the head repository Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-karlovskiy @pi0