Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix yui .focus() spec deviation. #646

Closed
wants to merge 1 commit into from
Closed

fix yui .focus() spec deviation. #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion architecture-examples/yui/js/views/todoview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,11 @@ YUI.add('todo-view', function (Y) {

// Turn on editing mode for the Todo by exposing the input field.
edit: function () {
var input = this.get('inputNode');

this.get('container').addClass('editing');
this.get('inputNode').focus();
input._node.value = input._node.value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment why this is necessary and what effect it has?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to position the cursor at the end of the line? This has the same effect as input._node.value += '';

input.focus();
},

// Get the value from our input field while hiding it, and
Expand Down