React - Improve performance by 6x #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2x: The unminified version contains invariants that shouldn't be used in production and slow it down. - 3x: Adding a shouldComponentUpdate override in order to short-cut re-rendering the component when props and state didn't change. In order to do that, we need to avoid doing mutations by doing a shallow copy and only modifying what changed - When React 0.5.0 will be released, it will give another 1.5x. Other miscellaneous changes: - Update class="..." to className="..." to work in 0.5.0 (still works in 0.4.1) - Use prop="..." instead of prop='...' - Use filter(f, this) instead of filter(f.bind(this)) to prevent a function allocaton
| todo.completed = !todo.completed; | ||
| this.setState({todos: this.state.todos}); | ||
| var newTodos = this.state.todos.map(function (t) { | ||
| if (t !== todo) { |
There was a problem hiding this comment.
don't use one char variable names
| @@ -92,8 +96,14 @@ | |||
| }, | |||
|
|
|||
| save: function (todo, text) { | |||
| todo.title = text; | |||
| this.setState({todos: this.state.todos, editing: null}); | |||
| var newTodos = this.state.todos.map(function (t) { | |||
There was a problem hiding this comment.
I think this could be a bit cleaner: Thoughts?
var newTodos = this.state.todos.map(function(t) {
return t !== todo ? t : Utils.extend({}, t, {title: text});
});
There was a problem hiding this comment.
I prefer the shorter one. @sindresorhus?
|
@sindresorhus @chenglou and I gave this a review last night before submitting. Outside of the single char variable name we're good with this. @jordwalke 's comments seem like a good idea though. |
|
Can we close this in favor of #702? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other miscellaneous changes: