-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart breaking changes #711
Conversation
id = json['id']; | ||
title = json['title']; | ||
completed = json['completed']; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation here looks a bit funny or is this just Github displaying it incorrectly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop, it's me. Default tab in Dart's IDE has changed, I had to clean all my tabs, forgot these lines =/
Cool, thanks! Is it worth recompiling the example at some point? |
Well, Dart release 1.0 is "coming soon". Let's wait for it ? |
@MathieuLorber SGTM |
For the record : 125ko for compiled version with the current SDK, versus 154 in the commited file... |
Nice to see enhancements there. Thanks again for the patch! |
Dart 1.0 is out =) I don't know why the polymer/angular implementations have not been proposed here ? @sethladd ? |
I didn't found the issue by searching just "dart" =) I mailed @sethladd yerterday actually, but he must be pretty busy at Devoxx for the moment =] |
+1 on the update to |
The Dart sample up to date !
I'll try to simplify code by using the suitable librairies next time...