Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart breaking changes #711

Closed

Conversation

MathieuLorber
Copy link
Contributor

The Dart sample up to date !

I'll try to simplify code by using the suitable librairies next time...

id = json['id'];
title = json['title'];
completed = json['completed'];
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here looks a bit funny or is this just Github displaying it incorrectly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, it's me. Default tab in Dart's IDE has changed, I had to clean all my tabs, forgot these lines =/

@passy
Copy link
Member

passy commented Nov 3, 2013

Cool, thanks! Is it worth recompiling the example at some point?

@MathieuLorber
Copy link
Contributor Author

Well, Dart release 1.0 is "coming soon". Let's wait for it ?

@passy
Copy link
Member

passy commented Nov 3, 2013

@MathieuLorber SGTM

@MathieuLorber
Copy link
Contributor Author

For the record : 125ko for compiled version with the current SDK, versus 154 in the commited file...

@passy passy closed this in 2a4d9f9 Nov 4, 2013
@passy
Copy link
Member

passy commented Nov 4, 2013

Nice to see enhancements there. Thanks again for the patch!

@MathieuLorber MathieuLorber deleted the dart-0.8.5.1_r28990 branch November 6, 2013 08:58
@MathieuLorber
Copy link
Contributor Author

Dart 1.0 is out =)
There's some minor changes (some deprecated calls) + it's time to update the compiled JS.
Now that polymer.dart and angular.dart are coming (and actually already have todomvc implementations...), I believe this sample should be moved to a vanilla-dart dir (as previously considered). WDYT ? (if so I'll do it with my next PR).

I don't know why the polymer/angular implementations have not been proposed here ? @sethladd ?

@passy
Copy link
Member

passy commented Nov 14, 2013

+1 for updating the example and moving it to dart-vanilla.

I don't know why the polymer/angular implementations have not been proposed here ? @sethladd ?

Who's saying that? :)

#714

@MathieuLorber
Copy link
Contributor Author

I didn't found the issue by searching just "dart" =)

I mailed @sethladd yerterday actually, but he must be pretty busy at Devoxx for the moment =]

@addyosmani
Copy link
Member

+1 on the update to dart-vanilla if possible. We're always happy to review other implementations submitted via PR for the other combinations.

This was referenced Nov 20, 2013
gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants