Knockout upgrade & escape fix #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenplusplus Mind looking over this? :) For a quick check: http://5minfork.com/passy/todomvc/tree/knockout-upgrade |
sindresorhus
added a commit
that referenced
this pull request
Nov 19, 2013
Knockout upgrade & escape fix
|
Nice work! lgtm and looks good to me. |
| Router({'/:filter': viewModel.showMode}).init(); | ||
| })(); | ||
| Router({ '/:filter': viewModel.showMode }).init(); | ||
| }()); |
|
Oops, forget a gif. Here u go: |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
Knockout upgrade & escape fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick sanity check please. :)
I upgraded Knockout to 3.0 and added the reverting behavior when pressing Escape. I kept both as separate commits.