-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh Cohere #141
refresh Cohere #141
Conversation
…s_configs/cohere-chat/configs.yaml and 3 other changes
…oards/evaluators/evaluators_leaderboard.csv
model_name: "command" | ||
mode: "chat" | ||
max_tokens: 2048 | ||
pretty_name: "Cohere Chat" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the chat model?
if it's because it was updated, can we get the updated results on the leaderboard instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chat mode of the command model was not really a different model before, just a different prompting style. These have been further unified (essentially turning plain instructions into single-turn chats), making them not worth listing as separate entries.
Having a single entry also will make it easier to give you more regular updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so client.chat
is being depreciated?
Then let's remove that from the code also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more for multi-turn chats, indeed less appropriate for tests like this. Removed in eb52df3
Nice improvement @sanderland! Congrats! Updating the command results with the last model makes sense thanks for doing that! However, let's refrain from removing models like cohere-chat unless there are updates. Considering that some papers reference the leaderboard, I think it's important to maintain consistency by keeping all models listed. Let me know your thoughts. |
Merged, thanks @sanderland ! |
I see there are various images and results that are derived from the old results. If you need anything else to update these, please let me know.