Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh Cohere #141

Merged
merged 12 commits into from
Oct 1, 2023
Merged

refresh Cohere #141

merged 12 commits into from
Oct 1, 2023

Conversation

sanderland
Copy link
Contributor

@sanderland sanderland commented Sep 30, 2023

  • Refreshes Cohere outputs to reflect the most recent model
    • Removes 'chat' entry as they were close before and this inference method is more stable.
  • Corrects pricing estimates
  • Some minor fixes for tests that were throwing warnings.

I see there are various images and results that are derived from the old results. If you need anything else to update these, please let me know.

model_name: "command"
mode: "chat"
max_tokens: 2048
pretty_name: "Cohere Chat"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the chat model?
if it's because it was updated, can we get the updated results on the leaderboard instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chat mode of the command model was not really a different model before, just a different prompting style. These have been further unified (essentially turning plain instructions into single-turn chats), making them not worth listing as separate entries.
Having a single entry also will make it easier to give you more regular updates.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so client.chat is being depreciated?
Then let's remove that from the code also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more for multi-turn chats, indeed less appropriate for tests like this. Removed in eb52df3

@YannDubs
Copy link
Collaborator

YannDubs commented Sep 30, 2023

Nice improvement @sanderland! Congrats!

Updating the command results with the last model makes sense thanks for doing that!

However, let's refrain from removing models like cohere-chat unless there are updates. Considering that some papers reference the leaderboard, I think it's important to maintain consistency by keeping all models listed. Let me know your thoughts.

@YannDubs YannDubs merged commit 0ac9b14 into tatsu-lab:main Oct 1, 2023
@YannDubs
Copy link
Collaborator

YannDubs commented Oct 1, 2023

Merged, thanks @sanderland !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants