Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add internlm2-chat-20b-ppo #207

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

C1rN09
Copy link
Contributor

@C1rN09 C1rN09 commented Jan 16, 2024

Hi, we are releasing internlm2 this week and here is our result on AlpacaEval.

The huggingface link is private now and will be public after its release. Hope to merge ASAP :)

Extra Modifications

The eos token, [UNUSED_TOKEN_145] for our model, seems to appear in the completion results. It might spoil the final score. So I added a remove_ending argument to huggingface_local_completions to strip this annoying word.

If this is not preferred, please let me know and we can work out another solution!

torch_dtype: "bfloat16"
trust_remote_code: True
is_fast_tokenizer: False
max_new_tokens: 2048
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that we typically use 4096 for newer models. 2048 is perfectly fine just saying in case some outputs are truncated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice!

Currently we haven't observed too many truncated completions. We suppose 2048 tokens is enough for our model. Responses above 2048 tokens are generally nonsense repetition, which might waste GPU time & GPT tokens

@YannDubs
Copy link
Collaborator

Very impressive results @C1rN09, I'll merge once you remove the reference_outputs!

@YannDubs YannDubs merged commit a1f070b into tatsu-lab:main Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants