Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Outbox publish command #33

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: Outbox publish command #33

wants to merge 4 commits into from

Conversation

warcooft
Copy link

No description provided.

MGatner
MGatner requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why you are getting the file contents and handling the write manually instead of using Publisher?

src/Commands/OutboxPublish.php Outdated Show resolved Hide resolved
@warcooft @MGatner
update typo src/Commands/OutboxPublish.php
03d0d07 
Co-authored-by: MGatner <mgatner@icloud.com>
@warcooft
Copy link
Author

warcooft commented Jul 5, 2024

@MGatner I'm not too familiar with the publisher, maybe next time I'll try using it.

@warcooft warcooft requested a review from MGatner July 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner Awaiting requested review from MGatner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warcooft @MGatner