Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[seer] use embedding #161

Closed
samyfodil opened this issue May 24, 2024 · 0 comments
Closed

[seer] use embedding #161

samyfodil opened this issue May 24, 2024 · 0 comments
Labels
good first issue No deep understanding of tau needed refactor Refactor multiple parts, or structure

Comments

@samyfodil
Copy link
Contributor

Seer types should be using embedding. See https://github.com/taubyte/tau/blob/main/protocols/seer/type.go

type oracleService struct {
	seer *Service
}

and

type geoService struct {
	seer *Service
}

Should be:

type oracleService struct {
	*Service
}

and

type geoService struct {
	*Service
}
@samyfodil samyfodil added refactor Refactor multiple parts, or structure good first issue No deep understanding of tau needed labels May 24, 2024
ldwangaqr added a commit to ldwangaqr/tau that referenced this issue Jun 3, 2024
@ldwangaqr
[seer] use embedding taubyte#161
37b4e11
samyfodil pushed a commit that referenced this issue Jun 3, 2024
@ldwangaqr
[seer] use embedding #161
a0eb1db
samyfodil pushed a commit that referenced this issue Jun 4, 2024
@ldwangaqr @samyfodil
[seer] use embedding #161
d8627eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue No deep understanding of tau needed refactor Refactor multiple parts, or structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samyfodil