Move away from inheriting Beat #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoei
commented
May 14, 2022
|
|
||
| namespace osu.Game.Rulesets.Tau.Objects.Drawables | ||
| { | ||
| public class DrawableSliderRepeat : DrawableBeat | ||
| public class DrawableSliderRepeat : DrawableAngledTauHitObject<SliderRepeat> |
There was a problem hiding this comment.
Still entirely unsure about this, on one hand inheriting from DrawableBeat would provide us with less copy-pasting of code, but on the other hand that would require us to add ... is not SliderRepeat again.
There was a problem hiding this comment.
I feel that would be a lot more precice in terms of the inheritence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this caused minor issues to us as a whole, for readability's sake this was a significant issue. More notably from the usage of
c => c is Beat and not SliderHeadBeat and not SliderRepeat and not SliderTick