Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/templates): add solid-start and solid-start-ts templates #274

Closed
wants to merge 1 commit into from
Closed

Conversation

AR10Dev
Copy link

@AR10Dev AR10Dev commented Dec 27, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    • Template

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

  • I have choose to use the default port 3000 of Solid-Start because there is a issue where the port specified in the Vite config is ignored
  • There are files dedicated to ssr in the dist/public folder because if I set ssr: false in the Vite config the build would fail. (link to the issue)

@amrbashir
Copy link
Member

Thanks for contribution but we are not currently accepting any more templates; in fact, some are being removed, see #258

@amrbashir amrbashir closed this Dec 27, 2022
@kevinseabourne
Copy link

any updates on this ? solid-start has made some big improvements and is close to full release now 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants