enhance: pack mods & key into a u32 as id instead of hashing #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Sep 9, 2024
amrbashir
requested changes
Sep 9, 2024
|
Yeah seems more reasonable to use 16 bits here for each value. Amended as requested, interesting note, I found a small discrepancy on the rust docs as well in the process: https://doc.rust-lang.org/reference/attributes/type_system.html. (Code is non_exhaustive, yet this runs perfectly well, I've opened a pr for that too) |
amrbashir
reviewed
Sep 9, 2024
|
Should be fine now. Thanks! |
amrbashir
approved these changes
Sep 9, 2024
amrbashir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change mentioned in #101.