-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(global-shortcut): enhance un/register
to accept an array, remove un/registerAll
#1117
Conversation
…/registerAll` closes #1101
un/register
to accept an array, remove un/registerAll
un/register
to accept an array, remove un/registerAll
Should we do the same on the Rust side? enum ShortcutArg {
Single(T),
List(Vec<T>),
}
impl From<T> for ShortcutArg { .. }
impl From<Vec<T>> for ShortcutArg { .. }
pub fn register(&self, shortcut: impl Into<ShortcutArg>) {...} Also should it unregister all registered shortcuts if the list is empty (or we provide a separate API for that)? |
I don't think we should do the same on Rust, it is better to be kept as is.
we could bring back |
Package Changes Through 307e2a7There are 4 changes which include global-shortcut with prerelease, global-shortcut-js with prerelease, http-js with prerelease, os-js with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
closes #1101