Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): use tokio oneshot channel for detecting abort #1395

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

amrbashir
Copy link
Member

closes #1376

@amrbashir amrbashir requested a review from a team as a code owner May 30, 2024 21:26
@amrbashir amrbashir changed the title fix(http): properly handle aborting fix(http): use tokio oneshot channel and detecting abort May 30, 2024
@amrbashir amrbashir changed the title fix(http): use tokio oneshot channel and detecting abort fix(http): use tokio oneshot channel for detecting abort Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Package Changes Through 760e9a8

There are 3 changes which include http with prerelease, http-js with prerelease, os-js with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-beta.12 2.0.0-beta.13
api-example-js 2.0.0-beta.10 2.0.0-beta.11
http 2.0.0-beta.11 2.0.0-beta.12
http-js 2.0.0-beta.7 2.0.0-beta.8
os-js 2.0.0-beta.6 2.0.0-beta.7

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

FabianLars
FabianLars previously approved these changes Jul 8, 2024
@FabianLars
Copy link
Member

wait, what's the macros feature flag for?

@amrbashir
Copy link
Member Author

for tokio::select!

@FabianLars
Copy link
Member

rooBlind

^Me missing the obvious

@amrbashir amrbashir requested a review from FabianLars July 8, 2024 13:04
@amrbashir amrbashir merged commit ac9a25c into v2 Jul 8, 2024
17 of 18 checks passed
@amrbashir amrbashir deleted the fix/http/cancellation branch July 8, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Request Cancellation Semantics
2 participants