Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global version_comparator #1919

Open
wants to merge 9 commits into
base: v2
Choose a base branch
from
Open

Conversation

n1ght-hunter
Copy link

This pr allows you do set a version_comparator when building the plugin that will get applied to all subsequent calls.
this does not change overriding if you call the builder manually but allows a way to alter version_comparator for js command calls

@n1ght-hunter n1ght-hunter requested a review from a team as a code owner October 11, 2024 09:21
Copy link
Contributor

github-actions bot commented Oct 13, 2024

Package Changes Through ed9e52a

There are 16 changes which include upload with minor, upload-js with minor, deep-link with patch, deep-link-js with patch, fs with minor, persisted-scope with minor, log-plugin with patch, log-js with patch, fs-js with patch, http with patch, localhost with minor, opener with major, opener-js with major, positioner-js with minor, positioner with minor, sql with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.5 2.0.6
api-example-js 2.0.2 2.0.3
deep-link-example-js 2.0.0 2.0.1
deep-link 2.0.1 2.0.2
deep-link-js 2.0.0 2.0.1
fs 2.0.3 2.1.0
fs-js 2.0.2 2.0.3
dialog 2.0.3 2.0.4
opener 1.0.0 2.0.0
opener-js 1.0.0 2.0.0
http 2.0.3 2.0.4
localhost 2.0.1 2.1.0
log-plugin 2.0.2 2.0.3
log-js 2.0.0 2.0.1
persisted-scope 2.0.3 2.1.0
positioner 2.0.2 2.1.0
positioner-js 2.0.1 2.1.0
single-instance 2.0.1 2.0.2
sql 2.0.2 2.0.3
upload 2.1.0 2.2.0
upload-js 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/lib.rs Outdated Show resolved Hide resolved
@n1ght-hunter
Copy link
Author

ok will fix it up this week

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n1ght-hunter This LGTM, can you also add a change file in .changes directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants