Add global version_comparator #1919
Conversation
Package Changes Through a40fbb2There are 8 changes which include dialog with patch, dialog-js with patch, positioner with patch, positioner-js with patch, http with patch, http-js with patch, shell with patch, shell-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| pub(crate) fn global_version_comparator(mut self, f: GlobalVersionComparator) -> Self { | ||
| self.global_version_comparator.replace(f); | ||
| self | ||
| } |
There was a problem hiding this comment.
this is the same as version_comparator method, no need to add a new one
There was a problem hiding this comment.
its not this one is in a Arc not a box. if you are fine with change the normal one to an Arc then alot of the boiler plate can be removed
|
|
||
| pub struct UpdaterBuilder { | ||
| app_name: String, | ||
| current_version: Version, | ||
| config: Config, | ||
| version_comparator: Option<Box<dyn Fn(Version, RemoteRelease) -> bool + Send + Sync>>, | ||
| global_version_comparator: Option<GlobalVersionComparator>, |
There was a problem hiding this comment.
no need to add a new field either
| @@ -93,12 +93,14 @@ impl RemoteRelease { | |||
| } | |||
|
|
|||
| pub type OnBeforeExit = Arc<dyn Fn() + Send + Sync + 'static>; | |||
| pub(crate) type GlobalVersionComparator = Arc<dyn Fn(Version, RemoteRelease) -> bool + Send + Sync>; | |||
There was a problem hiding this comment.
and this type can also be removed
| @@ -88,6 +93,10 @@ impl<R: Runtime, T: Manager<R>> UpdaterExt<R> for T { | |||
| builder = builder.current_exe_args(args); | |||
| } | |||
|
|
|||
| if let Some(version_comparator) = version_comparator { | |||
| builder = builder.global_version_comparator(version_comparator.clone()); | |||
There was a problem hiding this comment.
and then we can just call version_comparator here instead of global_version_comparator
This pr allows you do set a
version_comparatorwhen building the plugin that will get applied to all subsequent calls.this does not change overriding if you call the builder manually but allows a way to alter version_comparator for js command calls