fix(window-state): port fixes from v1 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(window-state): manual default implentation, closes #421 * Update lib.rs
amrbashir
force-pushed
the
fix/window-state/port-fixes
branch
from
3524d7c
to
b2cd19a
Compare
|
I have no idea why this check keeps failing while works locally, cc @FabianLars and @JonasKruckenberg |
|
i see the same issue locally too: It looks like it only concerns plugins that were present in v1 already and vscode shows that they are symlinks but clicking on them shows a "file not found" error. -> clean clone btw |
|
symlinks in git is so annoying, lol, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the following commits from v1 branch:
417c85a
617cf38
523bcdc