Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to tauri beta, add permissions #862

Merged
merged 36 commits into from
Feb 3, 2024

Conversation

tillmann-crabnebula
Copy link
Contributor

@tillmann-crabnebula tillmann-crabnebula commented Dec 29, 2023

This PR contains changes related to the new Allowlist/ACL feature in Tauri 2.0 for the Fs plugin.
These changes can be used by other plugins as examples to implement the new scoping/permission system.
The tauri-plugin crate needed for implementation of permission checks can be found in #8428

It adds:

TODO:

  • Scope check implementation for all exposed commands
  • Expose require_literal_leading_dot as plugin configuration value

@lucasfernog lucasfernog marked this pull request as ready for review January 29, 2024 20:48
@lucasfernog lucasfernog requested a review from a team as a code owner January 29, 2024 20:48
amrbashir
amrbashir previously approved these changes Jan 30, 2024
Comment on lines 28 to 34
// ensure scope entry is up to date
let dummy = ScopeEntry {
url: "https://tauri.app/*".into(),
};
let _ = scope::Entry {
url: dummy.url.parse().unwrap(),
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to define an impl From<ScopeEntry> for scope::Entry, no?

amrbashir
amrbashir previously approved these changes Jan 30, 2024
Copy link

socket-security bot commented Feb 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@tauri-apps/api@2.0.0-beta.0 None 0 514 kB tauri-apps-ci-user
npm/@tauri-apps/cli@2.0.0-beta.0 filesystem, shell 0 195 kB tauri-apps-ci-user
npm/vite@5.0.12 Transitive: environment, filesystem, network, shell +5 6 MB antfu, patak, soda, ...2 more

🚮 Removed packages: npm/@tauri-apps/api@2.0.0-alpha.13, npm/@tauri-apps/cli@2.0.0-alpha.20, npm/vite@5.0.6

View full report↗︎

lucasfernog
lucasfernog previously approved these changes Feb 3, 2024
@lucasfernog lucasfernog changed the title [FS] V2 Allowlist Implementation feat: update to tauri beta, add permissions Feb 3, 2024
@lucasfernog lucasfernog merged commit d198c01 into tauri-apps:v2 Feb 3, 2024
64 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants