-
-
Notifications
You must be signed in to change notification settings - Fork 249
feat: add set_dock_visibility method
#1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package Changes Through aca837cThere are 1 changes which include tao with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Signed-off-by: The1111mp <The1111mp@outlook.com>
Signed-off-by: The1111mp <The1111mp@outlook.com>
yeah that's a dev-only thing we'll need to fix on the tauri side later |
lucasfernog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty good - let's wait and see if we need to port any of the electron patches
Add
set_dock_visibilitymethod to support setting the visibility of the application in the dock.Close #105
As mentioned here, refer to
Electronto implementset_dock_visibilitymethod.This is my first PR, so there are some issues that need further confirmation:
set_dock_visibilityneed to be completely consistent withset_activation_policy. For example, we don’t need to do anything extra here: https://github.com/1111mp/tao/blob/c4d0f0555fb0f65993fa4f7b944c45465ed14211/src/platform_impl/macos/app_delegate.rs#L32dockerare consistent with the behavior ofElectron. More extensive testing may be needed...This is my local demo:

Should the icon change only occur in the local environment? I pointed tauri and tao directly to the local code by
patch.crates-ioand then started the demo project.Demo code: