fix(macos): crash sending key event when app has no windows #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when clicking the `Close Window` menu item which sends a `Cmd+W` event to the application. It looks like the window was closed and tao tried to send the event to `keyWindow` which was null. This check also exists on winit: https://github.com/rust-windowing/winit/blob/be1baf164cc80ebc8586f2c528fe854b1dafcb34/src/platform_impl/apple/appkit/app.rs#L36
Contributor
Package Changes Through 95b6777There are 1 changes which include tao with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when clicking the
Close Windowmenu item which sends aCmd+Wevent to the application. It looks like the window was closed and tao tried to send the event tokeyWindowwhich was null. This check also exists on winit:https://github.com/rust-windowing/winit/blob/be1baf164cc80ebc8586f2c528fe854b1dafcb34/src/platform_impl/apple/appkit/app.rs#L36