Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dialog Rust API, add note on path format for mobile #2765

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

lucasfernog
Copy link
Member

I'm not totally happy with how the dialog docs layout is completely different from the others, but I'm not willing to change it right now - especially not without discussing with the other docs maintainers

this PR clarifies the return path format for Android and iOS, and also updates the Rust examples following the change from tauri-apps/plugins-workspace#1842

I'm not totally happy with how the dialog docs layout is completely different from the others, but I'm not willing to change it right now - especially not without discussing with the other docs maintainers

this PR clarifies the return path format for Android and iOS, and also updates the Rust examples following the change from tauri-apps/plugins-workspace#1842
@lucasfernog lucasfernog requested a review from a team as a code owner October 1, 2024 13:53
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit d277025
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/66fbfed5fa05940008c28d96
😎 Deploy Preview https://deploy-preview-2765--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucasfernog lucasfernog merged commit e67e092 into v2 Oct 1, 2024
11 checks passed
@lucasfernog lucasfernog deleted the feat/dialog-api branch October 1, 2024 17:19
@goenning
Copy link

goenning commented Oct 2, 2024

image

I was trying to follow the example on the docs, but it doesn't seem to works. I'm being forced to do a "Yes".to_string().
Are the docs wrong or was this supposed to accept a &str?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants