Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples:todos-app]: Add vite #123

Merged
merged 2 commits into from
Jul 12, 2022
Merged

[examples:todos-app]: Add vite #123

merged 2 commits into from
Jul 12, 2022

Conversation

shinshin86
Copy link

In @sveltejs/kit there was a BREAKING CHANGE as follows.
Currently todos-app is not working because of this change, so i have a fix it.
sveltejs/kit#5332

shinshin86
shinshin86 commented Jul 11, 2022
View reviewed changes
examples/todos-app/src/styles/tailwind-output.css
@@ -433,11 +433,6 @@ input::-moz-placeholder, textarea::-moz-placeholder {
color: #9ca3af;
}

input:-ms-input-placeholder, textarea:-ms-input-placeholder {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that diff are being generated so I am pushing the fixes together.

@shinshin86 shinshin86 mentioned this pull request Jul 11, 2022
Closed
FabianLars
FabianLars approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a bunch!

@FabianLars
Copy link
Member

aahhh, almost. We require all commits to be signed. So if you could sign your commits, i can merge it right away ❤️

p.s. here's one possible guide https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@shinshin86
Copy link
Author

@FabianLars Thank you!

I have set up a signature for the commit.
I am pushing an empty commit with signed.
Is this alright with you?

@FabianLars
Copy link
Member

FabianLars commented Jul 11, 2022 •
edited
Loading

All commits need to be signed. i literally can not click on "Merge pull request" otherwise (blocked by github settings), so we'll need a force-push from you to overwrite the old commits :/

@shinshin86 shinshin86 force-pushed the examples_todos-app/add-vite branch from 17a9286 to af0f323 Compare July 12, 2022 00:11
@shinshin86 shinshin86 force-pushed the examples_todos-app/add-vite branch from af0f323 to bde3b04 Compare July 12, 2022 00:14
@shinshin86
Copy link
Author

@FabianLars OK!
I committed again with all commits signed and then force pushed.

@FabianLars FabianLars merged commit dd4b336 into tauri-apps:dev Jul 12, 2022
@shinshin86 shinshin86 deleted the examples_todos-app/add-vite branch July 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinshin86 @FabianLars