Skip to content

Commit

Permalink
fix(updater): Use escaped installer path when starting the updater msi
Browse files Browse the repository at this point in the history
Continuation of #7956
  • Loading branch information
amrbashir committed Nov 15, 2023
1 parent 9e3aff0 commit 0425260
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changes/updater-msi-escaped-path.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'tauri': 'patch:bug'
---

Escape path of the updater msi to avoid crashing on installers with spaces.
2 changes: 1 addition & 1 deletion core/tauri/src/updater/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ fn copy_files_and_run<R: Read + Seek>(
);
let _ = Command::new(msiexec_path)
.arg("/i")
.arg(found_path)
.arg(msi_path_arg)
.args(msiexec_args)
.arg("/promptrestart")
.spawn();
Expand Down

0 comments on commit 0425260

Please sign in to comment.