Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Symlinks inside updater bundle are not preserved on update #7480

Closed
Brendonovich opened this issue Jul 22, 2023 · 2 comments
Closed

[bug] Symlinks inside updater bundle are not preserved on update #7480

Brendonovich opened this issue Jul 22, 2023 · 2 comments
Labels
platform: macOS scope: core Core packages of Tauri status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@Brendonovich
Copy link
Member

Describe the bug

While #3933 describes an issue with creating updater bundles that contain symlinks, this is a slightly different problem.
We bundle FFMpeg as a macOS framework inside Spacedrive.app, and that framework contains symlinks to files within it.
When the updater extracts the downloaded update bundle, it doesn't preserve said symlinks, instead creating empty files.
This causes the app to instantly crash on launch as what should be symlinks are invaild files.

The top Finder window below is what the updater bundle should extract to. I downloaded the updater bundle from where it was being hosted (Firebase Storage) and extracted it, just to make sure it wasn't being affected by something other than the updater.
The bottom Finder window is the contents of the app bundle after running the updater. What were symlinks have become zero size files.
image

Reproduction

Will try to make a min repro, but it's a bit tricky since it requires having access to an update server

Expected behavior

No response

Platform and versions

[✔] Environment
    - OS: Mac OS 12.5.0 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.70.0 (90c541806 2023-05-31)
    ✔ Cargo: 1.70.0 (ec8a8a0ca 2023-04-25)
    ✔ rustup: 1.25.1 (2022-07-12)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 18.12.1
    - pnpm: 8.6.1
    - yarn: 1.22.19
    - npm: 8.19.2

[-] Packages
    - tauri [RUST]: 1.3.0
    - tauri-build [RUST]: 1.3.0
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: not installed!
    - @tauri-apps/cli [NPM]: 1.3.0 (outdated, latest: 1.4.0)

[-] App
    - build-type: bundle
    - CSP: default-src spacedrive: webkit-pdfjs-viewer: asset: https://asset.localhost blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'
    - distDir: ../dist
    - devPath: http://localhost:8001/
    - framework: React
    - bundler: Vite

Stack trace

No response

Additional context

No response

@lucasfernog
Copy link
Member

I believe #3934 fixed this. It's been mentioned #7773 is also related to this, which we'll merge for 1.5.

@Brendonovich
Copy link
Member Author

I believe #3934 fixed this. It's been mentioned #7773 is also related to this, which we'll merge for 1.5.

@lucasfernog I did test with only #3934 and it didn't fix it, but #7773 did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS scope: core Core packages of Tauri status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

3 participants