Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rpath missing from app, closes #7710 #7773

Merged
merged 11 commits into from
Sep 24, 2023
Merged

fix: rpath missing from app, closes #7710 #7773

merged 11 commits into from
Sep 24, 2023

Conversation

tr3ysmith
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • [ X] No

Other information

#7710

@tr3ysmith tr3ysmith requested a review from a team as a code owner September 7, 2023 14:37
@tr3ysmith tr3ysmith mentioned this pull request Sep 7, 2023
Closed
13 tasks
@Brendonovich
Copy link
Member

Seems like this also closes #7480. Symlinks in the Frameworks folder weren't being preserved but using this PR they are.

@Beanow Beanow added type: bug scope: core Core packages of Tauri status: needs review A maintainer must review this code platform: macOS security: needs feedback This issue/PR needs feeback from wg-security labels Sep 15, 2023
@lucasfernog lucasfernog mentioned this pull request Sep 15, 2023
Closed
lucasfernog
lucasfernog requested changes Sep 15, 2023
View reviewed changes
core/tauri-build/src/lib.rs Outdated Show resolved Hide resolved
@lucasfernog
Copy link
Member

Can you rebase your branch to sign the ef8a58d commit?

@tr3ysmith
Copy link
Contributor Author

Can you rebase your branch to sign the ef8a58d commit?

Should be good now

@tweidinger
Copy link
Contributor

Only concerns from sec perspective would be if @executable_path/../Frameworks is (world/all users) writeable, which from my understanding is not the case for apps properly deployed in macos (development seems a little different) and the application loading the relative libraries is not a suid binary, which is very rarely the case for a tauri application.

I think this would need to be documented for MacOS apps as risks for privilege escalation in case some privileged calls/libs/permissions are used/called from the Tauri app otherwise LGTM

@tweidinger tweidinger added security: feedback loop wg-security added some feedback but no conclusion based on feedbac and removed security: needs feedback This issue/PR needs feeback from wg-security labels Sep 20, 2023
@Brendonovich Brendonovich mentioned this pull request Sep 20, 2023
Merged
4 tasks
@lucasfernog
Copy link
Member

@tr3ysmith can you double check my latest commit and see if af13f20 (#7773) works fine on your setup?

@tr3ysmith
Copy link
Contributor Author

@tr3ysmith can you double check my latest commit and see if af13f20 (#7773) works fine on your setup?

Yeah that seems to work great, I was able to remove my build script and it worked.

@lucasfernog lucasfernog merged commit 5ecb46b into tauri-apps:1.x Sep 24, 2023
@tr3ysmith tr3ysmith deleted the rpath branch September 24, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@afonsojramos afonsojramos afonsojramos approved these changes

Assignees
No one assigned
Labels
platform: macOS scope: core Core packages of Tauri security: feedback loop wg-security added some feedback but no conclusion based on feedbac status: needs review A maintainer must review this code type: bug
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tr3ysmith @Brendonovich @lucasfernog @tweidinger @afonsojramos @Beanow