fix(nsis): properly handle Webview2 download return value #11131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NSIS template was changed in #9605 to use NSISdl instead of nsis_tauri_utils for downloading Webview2, but the return value handling was not adjusted from comparing against 0, to the return value of NSISdl::download:
The issue can be reliably reproduced with Windows Sandbox, which never has Webiew2 preinstalled.
This PR adjusts the NSIS template to properly check the return value.