fix: run_return not responding to restart
#13040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Package Changes Through 2021db0There are 1 changes which include tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Member
|
i think we should handle the restart on our end anyway, otherwise the API would look weird. |
lucasfernog
approved these changes
Apr 2, 2025
kandrelczyk
pushed a commit
to kandrelczyk/tauri
that referenced
this pull request
Apr 7, 2025
* fix: `run_return` not responding to `restart` * Document run_return will handle restart requests * Add change file
kandrelczyk
pushed a commit
to kandrelczyk/tauri
that referenced
this pull request
Apr 7, 2025
* fix: `run_return` not responding to `restart` * Document run_return will handle restart requests * Add change file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the
run_returnPR andrequest_restart/restartchange PRs happened at the same time, this didn't get into that functionSince
runandrun_returnshare the exactly same callback, moved it to a function