fix(core): raw channel message type regression #13268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Package Changes Through 4d73e29There are 1 changes which include tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
|
@WSH032 Hey could you give this PR a try and see if it fixes the regression? |
amrbashir
reviewed
Apr 21, 2025
crates/tauri/src/ipc/channel.rs
Outdated
| ))?; | ||
| } | ||
| InvokeResponseBody::Raw(bytes) if bytes.len() < MAX_RAW_DIRECT_EXECUTE_THRESHOLD => { | ||
| let formated_bytes = serde_json::to_string(&bytes)?; |
Member
There was a problem hiding this comment.
nit: why formated_bytes? isn't serialized_bytes a better name, or bytes_as_json?
Contributor
Author
There was a problem hiding this comment.
Changed name to bytes_as_json_array, didn't know what to name it, and formated_bytes was the first name popped in my head 🙃
amrbashir
previously approved these changes
Apr 21, 2025
amrbashir
approved these changes
Apr 21, 2025
WSH032
added a commit
to pytauri/pytauri
that referenced
this pull request
Apr 21, 2025
github-merge-queue bot
pushed a commit
to pytauri/pytauri
that referenced
this pull request
Apr 21, 2025
* feat(pytauri): accessing the request headers in `Commands` Added: - `pytauri.ipc.Headers` * docs: add tip about how to convert `ipc.Headers` to a dictionary * fix!: bump `tauri` to fix tauri-apps/tauri#13227 Rust: - tauri: 2.5 - tauri-build: 2.2 - tauri-plugin: 2.2 - tauri-utils: ~2.4 Js: - @tauri-apps/api: ^2.5 BREAKING CHANGE: This requires user to upgrade to `@tauri-apps/api: ^2.5`, corresponding to `tauri-plugin-pytauri-api: 0.5` * refactor: do not check `pyfunc` header at runtime * fix: bump `tauri` to `2.5.1` to fix tauri-apps/tauri#13268 * docs: changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13136 (comment)
Fix a regression introduced in #13138 that made the raw type messages received from
Channel.onmessagebecamenumber[]instead ofArrayBufferwhen that message is small