fix: main binary name can't contain dots #13429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13420
So we used to use
with_extensionto append the.exeon Windows, weirdly enough, this will replace the extension instead of appending one, so beforewith_added_extensiongets stabilized, we do this manuallyThis also adds the support for the bundler to pickup the binary name from nightly feature
different-binary-nameAnd documented how
mainBinaryNameworks