fix(cli): use original identifier to fix mobile options reading #13625
Conversation
the iOS and Android CLI commands leverage an android_studio_script/xcode_script that is executed by the native IDE or build tool. This script reads the Tauri configuration to find the app identifier used to communicate with the parent Tauri CLI process to read CLI options. The communication is broken when the `--config` arg is used, since the IDE script does not have access to that value before reaching the parent process, which is impossible without knowing the actual identifier used. To bypass this we'll agree on using the original identifier. This obviously won't work if the original tauri.conf.json do not have an identifier, so we error out in this case
Package Changes Through eba2156There are 8 changes which include tauri-bundler with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/cli with minor, tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
lucasfernog
changed the title
|
The code doesn't load on my phone, does this help with #13284 ? |
that's a different problem honestly.. it's related, but after initializing with the given identifier, the xcode_script/android_studio_script would still need to be able to know it.. we do have code to parse it from the Xcode project config, but for Android it's different (and would need to account for Kotlin vs Gradle syntax) |
|
this closes the actual bug reported on this comment #13284 (comment) |
the iOS and Android CLI commands leverage an android_studio_script/xcode_script that is executed by the native IDE or build tool. This script reads the Tauri configuration to find the app identifier used to communicate with the parent Tauri CLI process to read CLI options.
The communication is broken when the
--configarg is used, since the IDE script does not have access to that value before reaching the parent process, which is impossible without knowing the actual identifier used.To bypass this we'll agree on using the original identifier. This obviously won't work if the original tauri.conf.json do not have an identifier, so we error out in this case