Skip to content

Conversation

@Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Jul 8, 2025

Reference: #12182 (comment)

Follow up of #13759, since we use targetSdk 36 now, let's enable edge to edge to align the behavior on older android versions

@Legend-Master Legend-Master requested a review from a team as a code owner July 8, 2025 09:06
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Jul 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Package Changes Through c8af9e2

There are 4 changes which include @tauri-apps/api with patch, tauri-cli with patch, tauri-bundler with patch, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.6.0 2.6.1
tauri-utils 2.5.0 2.5.1
tauri-bundler 2.5.0 2.5.1
tauri-runtime 2.7.0 2.7.1
tauri-runtime-wry 2.7.1 2.7.2
tauri-codegen 2.3.0 2.3.1
tauri-macros 2.3.1 2.3.2
tauri-plugin 2.3.0 2.3.1
tauri-build 2.3.0 2.3.1
tauri 2.6.2 2.6.3
@tauri-apps/cli 2.6.2 2.6.3
tauri-cli 2.6.2 2.6.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Is this part of the comment you linked to in the pr not required (anymore)? (genuine question)

Then add implementation("androidx.activity:activity-ktx:1.9.3") to the dependencies section in gen/android/app/build.gradle.kts

@FabianLars
Copy link
Member

well, i guess CI answered my question

@Legend-Master
Copy link
Contributor Author

Really weird, it compiled fine on my machine with

dependencies {
    implementation("androidx.webkit:webkit:1.14.0")
    implementation("androidx.appcompat:appcompat:1.7.1")
    implementation("com.google.android.material:material:1.12.0")
    testImplementation("junit:junit:4.13.2")
    androidTestImplementation("androidx.test.ext:junit:1.2.1")
    androidTestImplementation("androidx.test.espresso:espresso-core:3.6.1")
}

so I assumed that's not needed

@Legend-Master Legend-Master merged commit cfc5bb8 into tauri-apps:dev Jul 9, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Jul 9, 2025
@Legend-Master Legend-Master deleted the android-template-edge-to-edge branch July 9, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants