-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(bundler/cli): Add feature flag to use system certificates #13824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package Changes Through a691fd7There are 9 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with patch, tauri with minor, @tauri-apps/api with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
#13358 is also veryyy loosely related |
|
I'm kinda new to this, what's the reason for us to use |
|
native-tls kinda sucks (iirc for us it was mostly about cross comp) - i think the ecosystem is also moving away from it (or at least considering it) eg seanmonstar/reqwest#2723 and platform verifier just never was on our minds before / back then 🤷 |
|
i also don't mind adding it directly but since i don't have any experience with it i thought that's a opt-out would be nice. On the other hand if it were to cause issues we'd release a hotfix that disables it for everyone so idk if the flag really makes sense. |
|
I see, thanks for the explanation and the link So from my understanding, outside of the cross compilation staffs (we don't cross compile our cli right?), the OS implementation of TLS might be flawed from the discussions under I feel like the flag probably doesn't help since that only works if they install the cli through cargo, maybe we could just do it and see if it actually breaks anything
|
guess so? idk, i didn't look that much into it and it was quite some time ago. it just didn't work (well) for us 🤷
i meant to enable it by default for the js cli as well. either way i guess i just drop the flag?
that sucks but i can't say i care 🫠 since this is only concerning dev machines i don't think it matters, what would you like to do? |
To be fair, since we already have a few other related flags, I don't mind having this feature flag
I would say yeah, go for |
opening this so i don't forget about it (i doubt that can happen since lately i get at least one report per week about this).
one question though, should we enable this by default or put it behind an env var or cli flag?