fix(windows): bundler should not sign non-binaries #13921
Conversation
Package Changes Through 41980a9There are 7 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with patch, tauri with minor, @tauri-apps/api with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| } | ||
|
|
||
| /// If the file is signable (is a binary file) and not signed already | ||
| /// (will skip the verification if not on Windows since we can't verify it) |
There was a problem hiding this comment.
well on macOS we could use codesign --verify
There was a problem hiding this comment.
on macos we need to sign all files and iirc the signature has to be the same for all files, not sure rn
There was a problem hiding this comment.
well on macOS we could use
codesign --verify
Does it verify Windows binaries?
on macos we need to sign all files and iirc the signature has to be the same for all files, not sure rn
Hmm, does that apply to Windows installers? Or do you mean codesign --verify checks a directory instead of a file?
I'm not familiar about how signing works on macOS, how do they store the signing info? (docs says it's stored in _CodeSignature/CodeResources which seems to be an xml file)
3 participants
The bundler will no longer try to sign non-binary and already signed binary files on Windows
Fix #13341
Note: didn't test yet