Skip to content

Conversation

@lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner August 19, 2025 10:00
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Aug 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Package Changes Through e217fdc

There are 1 changes which include tauri with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri 2.8.1 2.8.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor

Legend-Master commented Aug 19, 2025

I think it's (-p tauri) probably still not enough, with_environment clearly needs webview2_com which is also behind wry feature flag

@lucasfernog
Copy link
Member Author

well on Linux it showed me the error locally.. damn

@Legend-Master
Copy link
Contributor

Seems like the feature is enabled through this

tauri = { path = ".", default-features = false, features = ["wry"] }

from #3566

@lucasfernog
Copy link
Member Author

so cargo build will be able to do the check (like i tested locally) but not cargo test..

@Legend-Master
Copy link
Contributor

tauri = { path = ".", default-features = false, features = ["wry"] }

Do you still remember the reason for us to do this back then? Or maybe we could try removing this?

Also ideally we should remove the dependency on webview2-com and webkit2gtk in tauri-runtime

#13876 (comment)

@lucasfernog
Copy link
Member Author

Do you still remember the reason for us to do this back then? Or maybe we could try removing this?

the command tests needs this IIRC

Also ideally we should remove the dependency on webview2-com and webkit2gtk in tauri-runtime

we should refactor this for tauri 2.9

@lucasfernog lucasfernog merged commit 5075b67 into dev Aug 19, 2025
20 checks passed
@lucasfernog lucasfernog deleted the fix/build-without-wry branch August 19, 2025 10:42
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Aug 19, 2025
@Legend-Master
Copy link
Contributor

Also should we also put objc2-web-kit and related APIs to behind wry feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants