-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(bundle): add --no-sign flag to skip code signing in bundling pro… #14052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Legend-Master |
|
Thanks for the PR, but before a proper review, first I'll need ask you to cleanup the unrelated changes and things like |
|
Sure! |
57751ef to
10297b9
Compare
|
@Legend-Master The other changes are due to linter. |
You'll need to revert them as well |
177d464 to
a5febe6
Compare
…cess - Introduce a o_sign option in bundle settings to allow skipping code signing - Update macOS and Windows bundler implementations to respect the flag - Wire up CLI option --no-sign to control signing behavior during bundling - Add necessary config and type changes to propagate the flag throughout bundler Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
|
Thank you for your guidance @Legend-Master |
Package Changes Through 332f55fThere are 2 changes which include tauri-cli with minor, tauri-bundler with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Legend-Master
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also a change file
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
@FabianLars Since I'm not familiar with signing on macOS (I think it would fail if you have signingIdentity set but not the signing env vars), do you think we should also add this for macOS? I know we don't force the signing on Linux and the mobile signing process is not covered by tauri cli so probably don't need it for those platforms
| target_platform: TargetPlatform, | ||
| /// The target triple. | ||
| target: String, | ||
| pub no_sign: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pub no_sign: bool, | |
| no_sign: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this back to public, since making this private is breaking the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be put into a getter below instead of being pub here
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
o_sign flag in build options Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
o_sign private and add getter Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
Signed-off-by: ShigrafS <shigrafsalik@proton.me>
|
@Legend-Master @lucasfernog |
|
nah you're good, github shows no merge conflicts yet. we're just waiting for 2.9 to get a bit closer before we merge it. |
Description
This PR addresses an issue where building a Tauri application locally fails if code signing environment variables are not configured. It adds a new
--no-signCLI flag to thetauri buildcommand, allowing developers and contributors to easily create unsigned application bundles for testing and development purposes.Summary
This PR adds the
--no-signflag to thetauri buildcommand, streamlining the development workflow by allowing unsigned bundles to be built without the need for code signing keys. This is particularly useful for local testing, where the full build and install process can be checked without the overhead of configuring signing certificates.🧩 Related Issue
Closes #11626
[feat] build without signing cli flag✨ What's New
--no-signoption totauri buildandtauri bundle.tauri-bundlerto check for this flag and skip the code signing step for both macOS and Windows.no_signfield is added to the bundler'sSettingsstruct to pass this flag's state through the build pipeline.💡 Why This Matters
How has this PR been tested?
--no-signflag on both macOS and Windows to ensure that the signing process is correctly skipped.no_signflag is properly handled withintauri-bundler, preventing the call to the signing functions.Is this a breaking change?
Does this PR require an update to the documentation?
tauri buildandtauri bundleCLI references should be updated to include the new--no-signflag and its purpose.Checklist: