-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure custom protocol is handled as secure context on macOS #1551
Conversation
…content on macOS Do not seems to affect other platform need to test on Windows and linux to be sure it didn’t break anything. Fix #1550
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there were a flair possible for this kind of PR, then I would grant it legendary status that is literally a game changer. Thanks man. I owe you a caipi. On the Seychelles
I'm checking how local storage behaves with this solution. I think the webview caches it based on the url :/ |
maybe we could make sure local storage use |
That would be great |
macOSIt's stored inside WindowsWe already use with_user_data_folder so not a problem LinuxNeed to check this out |
webkit stores localstorage under |
Unfortunately |
ok I'll try to make some tests to see what we can do |
Since this is a macOS PR i'll merge it. |
I think we haven't enabled it yet but the method/signal should be here: |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)Other information:
Do not seem to affect other platforms need to test on Windows and Linux to be sure it didn’t break anything.
Fix #1550
Related to tauri-apps/wry#85
Without the fix:
With the fix