-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tauri-utils): include \n
in io::read_line
, closes #6388
#6519
Conversation
I see the value of keeping this compatible with the Rust std library, but I worry this is a breaking change for some users. Maybe we could target this for v2 instead. The use case of the issue is also a little weird ( Currently if the line does not end with |
tbh I see it as a bug fix so not a breaking change
While that maybe true, it is a bad DX (showcased in the example you added) and beside the use case of the issue, unix and windows had different behaviors which needs to align and if you align any of them to the other it will break for some users so I'd rather just fix the buggy behavior and align with rust. |
The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment)
The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from tauri-apps/tauri#6519 ref: tauri-apps/tauri#7684 (comment)
* fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment) * fix unix build * clippy * cleanup --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
* fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from tauri-apps/tauri#6519 ref: tauri-apps/tauri#7684 (comment) * fmt * dedup code
* fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from tauri-apps/tauri#6519 ref: tauri-apps/tauri#7684 (comment) * fmt * dedup code Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/9019432546 Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
* fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment) * fix unix build * clippy * cleanup --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
* fix(core/shell): speedup `Command.execute` & fix extra new lines (#9706) * fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment) * fix unix build * clippy * cleanup --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app> * lock file * minor --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app> Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information