Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Build the CLI for Windows ARM64, closes #7015 #7098

Merged
merged 2 commits into from
Jun 1, 2023
Merged

feat(cli): Build the CLI for Windows ARM64, closes #7015 #7098

merged 2 commits into from
Jun 1, 2023

Conversation

FabianLars
Copy link
Member

This worked locally, i bet 10 bucks that it will fail in CI

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: I have no idea which boxes to tick here

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary: We can't make Microsoft delete the arm64 windows version and ring takes ages for a new version so this is the next best thing.

Other information

btw, building tauri apps for arm still breaks as soon as people use something that depends on ring (like everything that uses rustls) 🥳

Closes #7015

@FabianLars FabianLars requested a review from a team as a code owner May 31, 2023 14:42
@wusyong wusyong merged commit 0ddbb3a into dev Jun 1, 2023
@wusyong wusyong deleted the cli/windows-arm64 branch June 1, 2023 03:04
@wusyong wusyong restored the cli/windows-arm64 branch June 1, 2023 03:04
@wusyong
Copy link
Member

wusyong commented Jun 1, 2023

Wait I think this should also add in next since we just merged dev into next recently.

@FabianLars
Copy link
Member Author

Are we done with merging dev into next? If so i can reopen it against next too, though we mayyy wanna test it first 😅

@wusyong
Copy link
Member

wusyong commented Jun 1, 2023

Yeah we've merged it. Could you also open one for next?

FabianLars added a commit that referenced this pull request Jun 1, 2023
@FabianLars
feat(cli): Build the CLI for Windows ARM64, closes #7015 (#7098)
3c81ba6 
* feat(cli): Build the CLI for Windows ARM64

* lockfile
@FabianLars FabianLars mentioned this pull request Jun 1, 2023
Merged
@FabianLars FabianLars deleted the cli/windows-arm64 branch June 1, 2023 11:09
FabianLars added a commit that referenced this pull request Jun 1, 2023
@FabianLars
ci: Use correct native-tls feature flags for win32-arm64 cli, ref #7098
af4c19d
@FabianLars FabianLars mentioned this pull request Jun 1, 2023
Merged
13 tasks
wusyong pushed a commit that referenced this pull request Jun 2, 2023
@FabianLars
ci: Use correct native-tls feature flags for win32-arm64 cli, ref #7098…
d7a0a2c 
… (#7107)
lucasfernog pushed a commit that referenced this pull request Jun 6, 2023
@FabianLars
feat(cli): Build the CLI for Windows ARM64, closes #7015 (#7098) (#7106)
3480047 
Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
closes #7015 (#7098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Provide @tauri-apps/cli-win32-arm64-msvc NPM package
2 participants
@FabianLars @wusyong