Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add std feature to raw-window-handle #9954

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix(core): add std feature to raw-window-handle #9954

merged 2 commits into from
Jun 4, 2024

Conversation

Legend-Master
Copy link
Contributor

Add std feature to raw-window-handle crate so that no default features can work

Reference: https://github.com/tauri-apps/plugins-workspace/actions/runs/9334978097/job/25730280072?pr=1402

@Legend-Master Legend-Master requested a review from a team as a code owner June 4, 2024 01:44
@Legend-Master Legend-Master mentioned this pull request Jun 4, 2024
Merged
amrbashir
amrbashir requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure how does enabling no-default-features affects raw-window-handle and I also can't reproduce the bug locally

.changes/raw-window-handle-std.md Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member

amrbashir commented Jun 4, 2024 •
edited
Loading

NVM, I was using the wrong name for default-features, still not sure how are they related.

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jun 4, 2024 •
edited
Loading

tauri uses thiserror to forward raw-window-handle's error, but this is only doable with std feature, currently we have it on tauri-runtime-wry which has tao which has raw-window-handle with std feature, but with not default features, we no longer depends on tauri-runtime-wry -> tao

@amrbashir amrbashir merged commit e6e17ad into tauri-apps:dev Jun 4, 2024
19 checks passed
@Legend-Master Legend-Master deleted the std-raw-window-handle branch June 4, 2024 02:30
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legend-Master @amrbashir