Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repository URLs for dependencies #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update repository URLs for dependencies #89

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2021

Build aborts with 525 errors, but at least all dependencies are retrieved now!

@emmyoh
Update repository URLs for dependencies
78600d4 
Build aborts with 525 errors, but at least all dependencies are retrieved now!
@ghost
Copy link
Author

ghost commented Jun 20, 2021 •
edited by ghost
Loading

I've tried regenerating the bindings, and I'm not sure if I'm doing it right, but whatever I'm doing isn't fixing the build errors?

I've run make gir in the root directory, which seems to be regenerating the bindings, and then running cargo fmt on them. This produces no difference with the current contents of src/auto in master.

EDIT: Never mind, I figured it out. I had to update the gir and gir-files submodules. Adding regenerated bindings in a new commit to this PR.

@emmyoh
Regenerated bindings
e103591 
Now build aborts after three errors
@ghost
Copy link
Author

ghost commented Jun 20, 2021 •
edited by ghost
Loading

It appears that the three remaining build errors are due to the fact that glib::translate::ToGlib no longer exists?

Ah, it appears it's now called into_glib. I've manually changed that, and now I'm getting 13 errors because gtk::{ContainerExt, WidgetExt} and webkit2gtk::{SettingsExt, WebContextExt, WebViewExt} cannot be found.

@emmyoh
Manually fixed gtk references
5610609 
`ToGlib` -> `IntoGlib`
`gtk::{ContainerExt, WidgetExt}` -> `gtk::prelude::{ContainerExt, WidgetExt}`

Now, building still fails because `SettingsExt`, `WebContextExt`, and `WebViewExt` don't exist in the `webkit2gtk` crate
@ghost
Copy link
Author

ghost commented Jun 20, 2021

Hopefully I'm helping in some manner? While I don't think I can progress further on my own as I'm unfamiliar with the inner workings of the GTK-rs project, I do think I've laid the groundwork for someone else to pick up where I left off

@jangernert jangernert mentioned this pull request Jul 1, 2021
Open
@ghost ghost mentioned this pull request Jul 15, 2021
Closed
@emmyoh
Corrected visibility of Ext traits
23f54b7 
This addresses #93 and builds upon the previous commits to this pull request.

Bear in mind that I have no idea what I'm doing—I've had to manually edit many automatically generated files throughout this PR (which I know I shouldn't have to be doing) to get this to work, but, hey, it works!

There are now eight warnings, and no errors.

I'm not sure if this can be merged just yet, for reasons such as code style and the whatnot; a review is still required
@ghost
Copy link
Author

ghost commented Jul 15, 2021 •
edited by ghost
Loading

I believe I'm pretty much done, as of my latest commit? I'm seeking outside review and tweaks, and hopefully this PR will get merged. Build errors have been resolved, and closes: #93.

@ghost ghost mentioned this pull request Jul 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmyoh