Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wkwebview): menu shortcuts #1208

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

thewh1teagle
Copy link
Contributor

Fix global menu shortcuts on macOS with multiwebview window, when adding webview as child.
Improved version of #1156 (comment)

@thewh1teagle thewh1teagle requested a review from a team as a code owner April 1, 2024 11:40
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works and I couldn't find a regression :) nice one!

@amrbashir amrbashir merged commit 29fbfd8 into tauri-apps:dev Apr 1, 2024
12 checks passed
pewsheen pushed a commit that referenced this pull request Apr 2, 2024
* fix(wkwebview): menu shortcuts

* Update wkwebview.md
lucasfernog added a commit that referenced this pull request Oct 11, 2024
* migrate drag & drop

* refactor: migrate to `dpi` crate (#1202)

* refactor: migrate to `dpi` crate

closes #1172

* macOS

* linux

* fix doctests

* imports

* more doctests

* fix android and ios

* Update examples/winit.rs

Co-authored-by: Jason Tsai <jason@pews.dev>

* Update src/webview2/mod.rs

---------

Co-authored-by: Jason Tsai <jason@pews.dev>

* fix(windows): avoid double-free the controller (#1206)

* fix(linux): Disable deprecated applicationCache web api. (#1207)

fixes tauri-apps/tauri#9300
ref WebKit/WebKit#23382

* fix(wkwebview): menu shortcuts (#1208)

* fix(wkwebview): menu shortcuts

* Update wkwebview.md

* Apply Version Updates From Current Changes (#1203)

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>

* migrate to `objc2`

* fix(macos): response body being double freed

* fix(macos): eval callback NSStrgin convertion error

* chore: remove objc dependency

* refactor(macos): migrate WebViewDelegate

* refactor(macos): migrate proxy to objc2

* refactor(macos): migrate document title change observer to objc2

* refactor(macos): move drag&drop handler to delegate

* refactor(macos): move ipc_handler into WryWebViewDelegate

* refactor(macos): migrate download handler

* fix(macos): prevent unsafe async custom protocol panic

* chore: target os import

* refactor(ios): migrate to objc2

* refactor(macos): migrate WebViewUIDelegate to objc2

* refactor(macos): migrate WryWebViewParent to objc2

* refactor(macos): move custom class to individual files

* chore: fix clippy

* refector: use reference for task. use objc2::exception::catch.

* fix(dnd): use msg_send super and impl NSDraggingDestination

* chore: call msg_send super

* fix: wrap Box<dyn FnMut(..)> with RefCell

* chore(deps): update rust crate tao to 0.29 (#1343)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor: use bitflags way to handle mask bit manipulation

* WIP: refactor(ios): add wkwebview for ios

* Update Cargo.toml

Co-authored-by: Mads Marquart <mads@marquart.dk>

* fix: remove `.copy()` from RcBlock

* add change file

* lint

* fmt

---------

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
Co-authored-by: thewh1teagle <61390950+thewh1teagle@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mads Marquart <mads@marquart.dk>
Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants