Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MacOS print options #1259

Merged
merged 8 commits into from
May 14, 2024

Commits on May 12, 2024

  1. feat: add MacOS print options

    Currently, when printing on a MacOS, it defaults to a quite big margin, which does not reflect the side of
    it when printing on the web. The current code just creates a new NSPrintInfo from the default, which for some
    reason has a large margin.
    
    This changes so that the default margin is 0 and add the option to change it when printing the webview on MacOs.
    This is not a field that can be changed by the user on the appkit modal, so it has to be defined before the modal is open.
    
    Other options could be added on top of these ones, but for this initial commit/PR decided to go with adding the margins
    since it seems to be the one with bigger discrepancy compared to the web version.
    
    References:
    - https://developer.apple.com/documentation/appkit/nsprintinfo
    augustoccesar committed May 12, 2024
    Configuration menu
    Copy the full SHA
    949c031 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. lint: apply cargo fmt

    augustoccesar committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a18a76f View commit details
    Browse the repository at this point in the history
  2. docs: add changelog

    augustoccesar committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b6bf4bf View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    921d297 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a08ba8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca1ac37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3868f65 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f4342d0 View commit details
    Browse the repository at this point in the history