Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with RFC3986 section 6.2.2.1 when getting Query String Parameters #63

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Comply with RFC3986 section 6.2.2.1 when getting Query String Parameters #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1842335
Mar 7, 2019
e26f036
Merge branch 'main' into RFC-3986
baywet Jun 28, 2023
aa37d8a
- adds a changelog entry for normalization fix
baywet Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Fixed lower normalization of query parameters. [#62](https://github.com/tavis-software/Tavis.UriTemplates/issues/62)

## [2.0.0]

- [Breaking] Updated Target Framework Moniker to `netstandard2.0` and drops `net35`, `net40`, `net45` and `netstandard1.0`.
Expand Down
2 changes: 1 addition & 1 deletion src/UriTemplates/UriTemplateExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public static Dictionary<string, object> GetQueryStringParameters(this Uri targe
var reg = new Regex(@"([-A-Za-z0-9._~]*)=([^&]*)&?"); // Unreserved characters: http://tools.ietf.org/html/rfc3986#section-2.3
foreach (Match m in reg.Matches(uri.Query))
{
string key = m.Groups[1].Value.ToLowerInvariant();
string key = m.Groups[1].Value; //RFC-3986 section 6.2.2.1 https://tools.ietf.org/html/rfc3986#page-11
string value = m.Groups[2].Value;
parameters.Add(key, value);
}
Expand Down