[wrangler] log startup time in version upload

Same as cloudflare#6318 , but for version upload Do not merge until API release is out (probably Jul 31).
taylorlee · Jul 30, 2024 · c76a31c · c76a31c
1 parent a9021aa
commit c76a31c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/.changeset/moody-baboons-wonder.md b/.changeset/moody-baboons-wonder.md
@@ -0,0 +1,5 @@
+---
+"wrangler": minor
+---
+
+log startup time in version upload
diff --git a/packages/wrangler/e2e/versions.test.ts b/packages/wrangler/e2e/versions.test.ts
@@ -60,6 +60,7 @@ describe("versions deploy", { timeout: TIMEOUT }, () => {
 
 		expect(normalize(upload.stdout)).toMatchInlineSnapshot(`
 			"Total Upload: xx KiB / gzip: xx KiB
+			Worker Startup Time: 100 ms
 			Worker Version ID: 00000000-0000-0000-0000-000000000000
 			Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 			To deploy this version to production traffic use the command wrangler versions deploy --experimental-versions
@@ -175,6 +176,7 @@ describe("versions deploy", { timeout: TIMEOUT }, () => {
 		expect(normalize(upload.stdout)).toMatchInlineSnapshot(`
 			"Total Upload: xx KiB / gzip: xx KiB
 			Worker Version ID: 00000000-0000-0000-0000-000000000000
+			Worker Startup Time: 100 ms
 			Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 			To deploy this version to production traffic use the command wrangler versions deploy --experimental-versions
 			Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy --experimental-versions

diff --git a/packages/wrangler/src/versions/upload.ts b/packages/wrangler/src/versions/upload.ts
@@ -415,8 +415,11 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 
 		printBindings({ ...withoutStaticAssets, vars: maskedVars });
 
-		if (!props.dryRun) {
+		if (props.dryRun) {
+			printBindings({ ...withoutStaticAssets, vars: maskedVars });
+		} else {
 			await ensureQueuesExistByConfig(config);
+			let bindingsPrinted = false;
 
 			// Upload the script so it has time to propagate.
 			// We can also now tell whether available_on_subdomain is set
@@ -430,6 +433,7 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 					pipeline_hash: string | null;
 					mutable_pipeline_id: string | null;
 					deployment_id: string | null;
+					startup_time_ms: number;
 				}>(
 					workerUrl,
 					{
@@ -445,8 +449,17 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 					})
 				);
 
+				logger.log("Worker Startup Time:", result.startup_time_ms, "ms");
+				bindingsPrinted = true;
+				printBindings({ ...withoutStaticAssets, vars: maskedVars });
 				logger.log("Worker Version ID:", result.id);
+
 			} catch (err) {
+
+				if (!bindingsPrinted) {
+					printBindings({ ...withoutStaticAssets, vars: maskedVars });
+				}
+
 				helpIfErrorIsSizeOrScriptStartup(err, dependencies);
 
 				// Apply source mapping to validation startup errors if possible