Git tag and hash #60
Merged
Git tag and hash #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating git tag and hash automatically upon building the binaries. there is an issue with the way the git tag is being generated in cmake.
if you clone the repo, the command that is being used: git describe --tag outputs:
latest
so this ends up being used as GAME_VERSION like so:
#define JK_VERSION EternalJK: latest
however, if you download the latest release, the JK_VERSION is actually:
#define JK_VERSION EternalJK: latest-22-g596ae40cc
so when cloning, its missing the amount of commits on top of the tagged objects and its missing the commit hash
$ git describe --tag --abbrev=0
latest
$ git rev-parse --short HEAD
c5d27eaea
then combine them so it becomes latest-c5d27eaea