-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vulkan backend #168
feat: vulkan backend #168
Conversation
@newfla As for your PR there is some issues despite all tests are passed. If you look into details - bindings not generated and it uses old, but some structures from public API were changed e.g. So we can split our efforts and leave one PR with updating to the new whisper.cpp version and another one with adding vulkan support. Or you can add missed parts to your PR, feel free to use my PR as reference. @tazz4843 Hi, please notice that all tests are passed, but really we have problems. What do you think about to disable implicit use of the bundled bindings at all or at least in CI runs? |
@arizhih |
@newfla I tried with whisper.cpp directly but it failed with error. I used the following commands: # Install vulkan from https://vulkan.lunarg.com/
git clone https://github.com/ggerganov/whisper.cpp
cd whisper.cpp
$env:VULKAN_SDK = "C:\VulkanSDK\1.3.290.0"
cmake -B build . -DGGML_VULKAN=ON -DGGML_CCACHE=OFF And got this error: -- Found Vulkan: C:/VulkanSDK/1.3.290.0/Lib/vulkan-1.lib (found version "1.3.290") found components: glslc glslangValidator
-- Vulkan found
CMake Error at ggml/src/CMakeLists.txt:613 (add_subdirectory):
The source directory
D:/whisper.cpp/ggml/src/vulkan-shaders
does not contain a CMakeLists.txt file. Looks like the build with volkan is a bit more complicated in WIndows: |
@thewh1teagle windows msvc is fine with this branch without doing anything special. |
@thewh1teagle I can confirm that with this commit ggerganov/whisper.cpp@fe36c90 (used in pr) you can build whisper.cpp with Vulkan, unfortunately master is broken right now |
Thanks. the specific commit works. Looks like master is broken as you said. By the way I couldn't enable openblas when compile |
@newfla |
@arizhih |
In that case closing in favor of 170 |
The PR introduces/modifies:
WHISPER_XYZ
cmake variables and changes to build artifacts foldersUnfortunately I can't test on macos. I would be very happy if someone could give me some feedback on that platform.